Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter exact list prefix matches for MemoryStore and HttpStore (#3712) #3713

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Filter exact list prefix matches for MemoryStore and HttpStore (#3712) #3713

merged 2 commits into from
Feb 13, 2023

Conversation

tustvold
Copy link
Contributor

Which issue does this PR close?

Part of #3712

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the object-store Object Store Interface label Feb 13, 2023
tustvold
tustvold commented Feb 13, 2023
View reviewed changes
object_store/src/memory.rs
let mut parts = match k.prefix_match(prefix) {
Some(parts) => parts,
None => break,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic was just wrong, as it could cause it to bail out early if the store contained any paths less than the prefix that didn't match. This is now caught by the additional tests in list_uses_directories_correctly

alamb
alamb approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me -- thank you @tustvold

object_store/src/lib.rs Show resolved Hide resolved
@tustvold @alamb
Update object_store/src/lib.rs
bc662f9 
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@tustvold tustvold merged commit 38a79ae into apache:master Feb 13, 2023
@ursabot
Copy link

ursabot commented Feb 13, 2023

Benchmark runs are scheduled for baseline = 5ffc0a8 and contender = 38a79ae. 38a79ae is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
object-store Object Store Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tustvold @ursabot @alamb